Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH #500 update references to renamed AppShell component #529

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

jcalcaben
Copy link
Contributor

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[X] Documentation

Summary

When this pull request is merged, it will update AppShell references in the doc to use its new name: App.

Additional information

This PR closes #500

@jcalcaben jcalcaben self-assigned this Nov 19, 2018
@jcalcaben jcalcaben requested a review from awilcoxa November 19, 2018 19:33
@vercel
Copy link

vercel bot commented Nov 19, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage remained the same at 17.555% when pulling 71c25c4 on jimothy/gh-500_update-appshell-references into b81dbb2 on release/2.0.

@awilcoxa
Copy link

There's a reference to "application shell" versus "application" assuming this is an intentional/appropriate use in the following line: "This lets the application shell update content..."

@jimbo
Copy link
Contributor

jimbo commented Nov 19, 2018

@jcalcaben My bad; should have let you know when I pushed the change. 😅

@jcalcaben jcalcaben merged commit fd9b590 into release/2.0 Nov 19, 2018
@jcalcaben jcalcaben deleted the jimothy/gh-500_update-appshell-references branch November 19, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants