Fallback page for disabled js in browser #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKaryka
requested review from
zetlen,
jimbo,
Starotitorov and
supernova-at
AlexeyKaryka
force-pushed
the
feature/fallback-if-js-anavailable
branch
2 times, most recently
from
6094821 to
d570f31
Compare
AlexeyKaryka
force-pushed
the
feature/fallback-if-js-anavailable
branch
from
d570f31 to
5743882
Compare
4 tasks
zetlen
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Thanks @AlexeyKaryka, this looks great. I made some small adjustments to the build and the fallback view. We'll want to come back to this in later enhancements, so that we can reuse core Venia styles by creating the fallback template as a build asset. But this works great for now. Nicely done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[ X ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
When this pull request is merged, it will add fallback page for the case when js is disabled in browser
When js is disabled, common font which is used all around the project isn't fetched anymore, so I've added src on this font from the google fonts.