Product options #550
Merged
Product options #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimbo
commented
Nov 27, 2018
jimbo
commented
Nov 27, 2018
jimbo
commented
Nov 27, 2018
jimbo
commented
Nov 27, 2018
zetlen
suggested changes
Nov 27, 2018
There was a problem hiding this comment.
This code is high quality and basically ready for merge. Thank you, @pcvonz and @jimbo, for working so hard on it.
I shoot it back as "request changes" only because of one or two small tweaks, and a general need for comments in the areas where we're doing something weird. I can add these comments if necessary before merge, but you can if you prefer.
packages/venia-concept/src/components/ProductFullDetail/ProductFullDetail.js
Outdated
Show resolved
Hide resolved
packages/venia-concept/src/components/ProductFullDetail/ProductFullDetail.js
Show resolved
Hide resolved
packages/venia-concept/src/components/ProductFullDetail/ProductFullDetail.js
Outdated
Show resolved
Hide resolved
This was referenced Nov 27, 2018
|
Storybook is missing again. But I think that can be handled in a separate issue. |
zetlen
approved these changes
Nov 27, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will enable shoppers to select values for configurable options and purchase configurable products.
Additional information