Fix category tile presentation #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimbo
commented
Nov 27, 2018
| max-width: 100%; | ||
| width: auto; | ||
| height: 100%; | ||
| opacity: 0; |
There was a problem hiding this comment.
Hide the image, but not from screen readers. It should be there, and if you right click the tile, the context menu should give you actions related to the image element (e.g., View image).
jimbo
commented
Nov 27, 2018
| @@ -6,22 +6,21 @@ | |||
| } | |||
|
|
|||
| .imageWrapper { | |||
| background-image: var(--venia-image); | |||
| background-position: 50% 50%; | |||
| background-size: cover; | |||
There was a problem hiding this comment.
This is what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will fix the presentation of the category tiles.
Additional information
Tiles should use
background-image, so that we can use CSS to control the presentation and make use of imperfect images.