Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang to the app shell #630

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

AlexeyKaryka
Copy link
Contributor

This PR is a:

  • New feature
  • Enhancement/Optimization
  • Refactor
  • Bugfix
  • Test for existing code
  • Documentation

Summary

When this pull request is merged, it will add lang attribute, so that accessibility of app will be increased

Additional information

@vercel
Copy link

vercel bot commented Dec 10, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Dec 10, 2018

Coverage Status

Coverage remained the same at 21.562% when pulling 0ac2672 on AlexeyKaryka:feature/add-lang-to-app-shell into 9345412 on magento-research:release/2.0.

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants