Dockerfile #682
Closed
Dockerfile #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Generated by 🚫 dangerJS |
sharkySharks
force-pushed
the
dockerfile
branch
from
c5d3578 to
a258335
Compare
sharkySharks
force-pushed
the
dockerfile
branch
from
a258335 to
cb437c4
Compare
sharkySharks
commented
Dec 20, 2018
| MAGENTO_BACKEND_URL="https://release-dev-rxvv2iq-zddsyhrdimyra.us-4.magentosite.cloud/" | ||
| MAGENTO_BUILDPACK_PROVIDE_SECURE_HOST=0 | ||
| PWA_STUDIO_PORTS_DEVELOPMENT=8080 | ||
| ENABLE_SERVICE_WORKER_DEBUGGING=1 |
There was a problem hiding this comment.
how do we get service workers running on secure hosting from a docker container.
|
work is in progress and will be updated here soon. tracking this under #734 |
|
adding hold label until I update work here with https support |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will allow users to run PWA inside of a docker container. Users will also have the ability to mount their filesystem to the container and webpack hot reloading will continue to work with both changes on the host system as well as in the container.