Update order detail page #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
| onBuyAgain={onBuyAgain} | ||
| onShare={onShare} | ||
| /> | ||
| <div className={classes.list}>{props.children}</div> |
There was a problem hiding this comment.
We should remove "Buy Again" and "Share" from the "Interactions" section in the docs.
There was a problem hiding this comment.
Actually, I should just add this functionality back. It looked like it was just mocked.
There was a problem hiding this comment.
After further review, it basically is mocked. The share logic is a total hack, and the add-to-cart functionality doesn't work since all the data is mocked. Going to stub things out and write a couple tests. I think the docs can stay unchanged that way.
...concept/src/components/PurchaseDetailsPage/PurchaseDetails/__tests__/purchaseDetails.spec.js
Outdated
Show resolved
Hide resolved
sirugh
approved these changes
Jan 18, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, the order detail UI will be more legible, use the new button styles, and have simpler tests.