Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDVA-12304_2.2.5.patch #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakebrinkmann
Copy link

@jakebrinkmann jakebrinkmann commented Feb 12, 2025

Updates for magento/product-community-edition@2.4.6-p9

> php ./vendor/bin/magento-patches apply MDVA-12304
Error: patch MDVA-12304 can't be applied
Magento 2 Community Edition, version 2.4.6.0-patch9
Applying patch MDVA-12304 (.../vendor/magento/quality-patches/src/../patches/os/MDVA-12304_2.2.5.patch) failed.
error: patch failed: vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php:29
error: vendor/magento/framework/Stdlib/Cookie/PhpCookieManager.php: patch does not apply

Script php ./vendor/bin/magento-patches apply MDVA-12304 handling the post-install-cmd event returned with error code 1

Updates for magento/product-community-edition@2.4.6-p9
@jakebrinkmann
Copy link
Author

In the meantime, I'm going ahead rolling our own patch:

  • patches/composer/magento/framework/MDVA-12304-patch.patch
--- a/Stdlib/Cookie/PhpCookieManager.php	2025-02-13 09:04:18
+++ b/Stdlib/Cookie/PhpCookieManager.php	2025-02-13 09:04:31
@@ -31,7 +31,7 @@
      * RFC 2109 - Page 15
      * http://www.ietf.org/rfc/rfc6265.txt
      */
-    private const MAX_NUM_COOKIES = 50;
+    private const MAX_NUM_COOKIES = 200;
     public const MAX_COOKIE_SIZE = 4096;
     private const EXPIRE_NOW_TIME = 1;
     private const EXPIRE_AT_END_OF_SESSION_TIME = 0;
  • composer.patches.json
        "magento/framework": {
            "Allow 200 cookies (MDVA-12304)": "patches/composer/magento/framework/MDVA-12304-patch.patch"
        },

@hostep
Copy link

hostep commented Feb 25, 2025

In version 1.1.60 of quality patches, the patch MDVA-12304 has been replaced by ACSD-64710 for the latest Magento security releases.

So I guess we can close this PR here now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants