-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load recaptcha related files on focus of the form fields. #334
base: develop
Are you sure you want to change the base?
Load recaptcha related files on focus of the form fields. #334
Conversation
@magento give me 2.4-develop instance |
Hi @Bashev. Thank you for your request. I'm working on Magento instance for you. |
Hi @Bashev, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
@magento give me 2.4-develop instance |
Hi @Bashev. Thank you for your request. I'm working on Magento instance for you. |
Hi @Bashev, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
Co-authored-by: Dan Wallis <dan@wallis.nz>
Co-authored-by: Dan Wallis <dan@wallis.nz>
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@Bashev, unfortunately, I don't have write permissions to this repo.
to
so that two issues will be automatically closed when this PR will be merged |
@magento run Functional Tests CE, Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@ihor-sviziev @fredden, I think the error from the failed test is not related to the PR. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@Bashev, I saw the comment from @techtoni in magento/magento2#38303 (comment):
It looks like this PR actually changes behavior for v2 invisible and v3 invisible, which means v3 might work incorrectly due to this change. Could you please double-check that? |
@ihor-sviziev i saw the comment also, and also read the documentation.
Works best not means, it's mandatory. From my point of view this not break the rules of reCAPTCHA. Yes probably this will have some negative impact of the scoring, but will be acceptable. All of us knows, Google uses reCAPTCHA also to track user behavior and this is the main reason for which they want to have it on all pages. |
@magento run Functional Tests CE |
Co-authored-by: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>
Description (*)
reCaptcha remote files will be loaded only if customer (visitor) focus on the fields for the form for which reCaptcha is enabled. This will reduce loaded files and immediately reflects to loading time.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)