PHP73 Compatibility #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reak'. Did you mean to use 'continue 2'
…ing-continue-in-switch MC-16959: 4) Warning: 'continue' targeting switch
|
|
paliarush
reviewed
Jul 25, 2019
| @@ -898,7 +898,7 @@ protected function _parseCmapTable() | |||
| if ($language != 0) { | |||
| $this->_debugLog('Type 0 cmap tables must be language-independent;' | |||
| . ' language: %d; skipping', $language); | |||
| continue; | |||
| break; | |||
There was a problem hiding this comment.
This break can be omitted.
Has anyone tested the effect of this change?
There was a problem hiding this comment.
Yes - can be removed - I tested it and create new PR:
magento-techdivision#2
…ing-continue-in-switch MC-16959: remove omitted break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to support php7.3