New configuration option for free late badges #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -564,7 +567,7 @@ def new(self, session, show_all='', message='', checked_in=''): | |||
| if show_all: | |||
| restrict_to = [Attendee.paid == c.NOT_PAID, Attendee.placeholder == False] | |||
| else: | |||
| restrict_to = [Attendee.registered > datetime.now(UTC) - timedelta(minutes=90)] | |||
| restrict_to = [Attendee.paid != c.NEED_NOT_PAY, Attendee.registered > datetime.now(UTC) - timedelta(minutes=90)] | |||
There was a problem hiding this comment.
Although we'll probably stop using this page once badges becomes free, it struck me that there's never any reason for a need not pay badge to ever show up here, so I added that filter. Now free badges added by admins on-site won't show up here either.
|
The configspec.ini comment was confusing, but other than that this looks good. |
|
Just fixed the configspec comment typo, so I'll merge this now. |
EliAndrewC
added a commit
that referenced
this pull request
Feb 14, 2016
New configuration option for free late badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1682