Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #1 #2

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Fixes issue #1 #2

merged 2 commits into from
Jan 11, 2018

Conversation

jancinert
Copy link
Contributor

No description provided.

c9s
c9s requested changes Jan 11, 2018
View reviewed changes
src/Universal/Query/CreateTableQuery.php Outdated
{
$col = new Column($name);
if (gettype($col) == 'string') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_string is faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jancinert
jancinert commented Jan 11, 2018
View reviewed changes
Copy link
Contributor Author

@jancinert jancinert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

@jancinert
Copy link
Contributor Author

Is anything to do to resolve the PR?

@c9s
Copy link
Member

c9s commented Jan 11, 2018

Nope thanks!

@c9s c9s merged commit 4b410cc into maghead:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jancinert @c9s