Fixed memory leaks in concurrent tests #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusnaslund
force-pushed
the
concurrentmemleaks
branch
3 times, most recently
from
43e2acd to
089c72b
Compare
| allocated: static Int = 0 | ||
| freed: static Int = 0 |
There was a problem hiding this comment.
This way we can actually remove the created classes, otherwise they could never be freed.
|
Peer review @erikhagglund ? |
|
Taking this off review again, I will add some more stuff. |
marcusnaslund
force-pushed
the
concurrentmemleaks
branch
from
089c72b to
82c3379
Compare
|
There we go. Peer review @erikhagglund or @sebastianbaginski , whoever has time |
| @@ -84,6 +84,8 @@ ThreadTest: class extends Fixture { | |||
| otherId free() | |||
| (job as Closure) free() | |||
| expect(myId equals(Thread currentThreadId()), is true) | |||
| thisThreadInstance free() | |||
| otherThreadInstance free() | |||
ghost
added
marcusnaslund
force-pushed
the
concurrentmemleaks
branch
from
82c3379 to
2f1c377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work on #1699
Eliminating these wasteful leaks have shown some leaks in
Promise,PromiseCollector, andThreadPoolthat would occur if they're used in ways not currently used today. They will be fixed in a later PR.