Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FloatTuple. #837

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Conversation

emilwestergren
Copy link
Contributor

As part of https://github.com/cogneco/ooc-kean/issues/783 I have implemented FloatTuple which holds 2, 3 and 4 Floats. This will be used for cases where types like FloatPoint/FloatVector are not valid.

@emilwestergren
Copy link
Contributor Author

@simonmika peer review?

@simonmika
Copy link
Contributor

This is good.

@marcusnaslund
Copy link
Contributor

Do we really want this in base and not in math?

@emilwestergren
Copy link
Contributor Author

Yes, it's not related to math.

@marcusnaslund
Copy link
Contributor

Alright, then.

marcusnaslund added a commit that referenced this pull request Nov 19, 2015
@marcusnaslund marcusnaslund merged commit 396ef74 into magic-lang:master Nov 19, 2015
@emilwestergren emilwestergren deleted the floattuple branch November 20, 2015 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants