Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct keys when parsing action URL and custom Attributes from notification response #16

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

stigi
Copy link
Member

@stigi stigi commented Apr 25, 2024

The Android SDK was using outdated keys for both, actionUrl and customAttributes.

I've created a broadcast via the CLI that contains both, action-url and custom attributes:

magicbell broadcasts create --action-url "act://ion" --content "Via CLI" --title "Check this Broadcast" --custom-attributes '{custom:"Value"}' --recipients "hi@ullrich.is"

Here's the API response that clearly shows the names of the keys. I've updated the parser accordingly.
CleanShot 2024-04-25 at 10 48 48@2x

Test Plan

I was able to confirm in the debugger that the correct values arrive now.

CleanShot 2024-04-25 at 10 47 09@2x

@stigi stigi merged commit c49521d into main Apr 28, 2024
@stigi stigi deleted the ullrich/fix-action-url+custom-values branch May 9, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants