fix: sync stores to match context on mark-all-as-read #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull ensures that when having multiple stores, of which one holds read notifications and another unread, notifications are properly synchronised when clicking "mark all read".
Before this change, clicking "mark all read" in an inbox that only shows unread notifications (
{ read: false }), would not remove those notifications from the current tab. Nor would they appear in a tab thats configured with{ read: true }.Note that the implementation is still optimistic. Meaning, we move all notifications around, regardless of other parameters like category or custom attribute matchers.