Duplicated input name in QSO edit

[leroydiazg]

While working in #827 , I noticed that t both Frequency and Frequency(RX) fields have the same name , which could be problematic.

Anyway, I suspect this file is not being in use at this moment, (is it?), as I see that in 'edit_ajax' view they are not the same.

Cloudlog/application/views/qso/edit.php

Lines 70 to 80 in 31e2107

	<div class="form-group">
	<label for="freq">Frequency</label>
	<input type="text" class="form-control" id="freq" name="freq" value="<?php echo $qso->COL_FREQ; ?>">
	</div>
	<div class="form-group">
	<label for="freq">RX Frequency</label>
	<input type="text" class="form-control" id="freq" name="freq" value="<?php echo $qso->COL_FREQ_RX; ?>">
	</div>

[magicbug]

PR Merged which resolves this

[leroydiazg]

I was reviewing the issues I opened here and I've just seen this closed. I think you might have misunderstood me, as what I fixed in #826 was the QSO Labels not this issue with the frequency name .

This issue can still be seen in master.

Anyway, I still think this file is not used, as in edit_ajax.php these names are not the same.

[AndreasK79]

@leroydiazg edit.php isn't in use anymore. It was changed over when adding bootstrapdialog. At the time, both files were needed, but after everything was changed, it's not used.

I submitted a PR deleting this file, and fixing the id for the two frequency files in edit_ajax. Were there any more issues in edit_ajax?

[leroydiazg]

Thanks @AndreasK79 , it's clear now :)

I didn't see any more issues, but honestly I can't be sure 100%. I noticed this one while @dgdavid and I were trying to fix the QSO form labels and Spanish translations. We haven't looked in depth as we have a lot to learn about ham radio before fully understanding the whole project.

[AndreasK79]

@leroydiazg thanks for letting us know. And we very much appreciate that you and @dgdavid are contributing to this project.

[dgdavid]

@AndreasK79,

Thanks to you too for your kind words as well as for addressing it in #876. From our side, it is not only our aim of contributing to open source projects but also de pressure of having a radio ham father 😜 😉