Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QSO] Auto population of state when you have had a prior QSO #854

Closed
magicbug opened this issue Jan 27, 2021 · 2 comments
Closed

[QSO] Auto population of state when you have had a prior QSO #854

magicbug opened this issue Jan 27, 2021 · 2 comments
Labels
Bug Ah shit, we broke something

Comments

@magicbug
Copy link
Owner

Looks like I screwed something in the JSON that grabs call information, if you have had a previous contact the state field isn't populated, this needs fixed.

@magicbug magicbug added the Bug Ah shit, we broke something label Jan 27, 2021
@AndreasK79
Copy link
Contributor

AndreasK79 commented Feb 8, 2021

You haven't screwed with anything there. As far as I can read the code, state is never fetched. I added it locally, but things are only set if a name is set on the previous QSO.

From logbook.php line 118:
// Do we have local data for the Callsign? if($this->logbook_model->call_name($callsign) != null)

Usually a name is set, but not always. Perhaps the logic needs a rewrite, as well as getting the state?

@AndreasK79
Copy link
Contributor

Wouldn't it be better to just fetch the latest qso based on callsign, ordered by logged time and limit 1? Then fill the array with information? The way it is done now, several calls are made to the database.

magicbug added a commit that referenced this issue Feb 8, 2021
Fetches state from previous QSO. Fixes #854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Ah shit, we broke something
Projects
None yet
Development

No branches or pull requests

2 participants