Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto QTH function configurable on frontend #1705

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Oct 19, 2022

This addresses #1698 and make it user-configurable on frontend.

@phl0
Copy link
Contributor Author

phl0 commented Oct 19, 2022

Seems this one includes the WWFF lookup as well because I branched off that one... Might have to refactor this when WWFF gets merged.

@m0urs
Copy link
Contributor

m0urs commented Oct 19, 2022

In general both functions are working for me. However, automatic creation of the missing field "user_qth_lookup" did not work. Both "application/migrations/103_add_user_wwff_lookup.php" and "application/migrations/104_user_auto_qth_option.php" are creating the same field ("user_wwff_lookup"). Looks like a copy&paste error?

@phl0
Copy link
Contributor Author

phl0 commented Oct 19, 2022

Probably right. I will check and correct.

@m0urs
Copy link
Contributor

m0urs commented Oct 19, 2022

And maybe it would be possible to also change the link, which appears after entering a WWFF reference, from WWFF to https://www.cqgma.org/ ?

@phl0
Copy link
Contributor Author

phl0 commented Oct 19, 2022

Mistake fixed. The WWFF link stuff is handled in #1699.

@m0urs
Copy link
Contributor

m0urs commented Oct 19, 2022

Ok, I only changed one link in #1699 yet, so I will change the other occurence as well in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants