Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button that leads to search for other QSOs with the same DX station #1706

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Oct 19, 2022

Thought this could be useful (saves me from copying the callsign to the search box). With a click on the button you will be directed to a search for QSOs with the same DX station.

Screenshot from 2022-10-19 23-26-20

@AndreasK79
Copy link
Contributor

Tested working ok.

Though while testing, I did find that search acts strange when the call has a / in it. It searches for everything that contains what is in front of the slash in the call. I don't know if this is intentional, or a bug.

@phl0
Copy link
Contributor Author

phl0 commented Oct 23, 2022

Tnx for testing. I can confirm the issue with slashes in the callsign though it is not caused by this patch as far as I can see. Will see if I can find a solution.

@phl0
Copy link
Contributor Author

phl0 commented Oct 26, 2022

Though while testing, I did find that search acts strange when the call has a / in it. It searches for everything that contains what is in front of the slash in the call. I don't know if this is intentional, or a bug.

Strange. I cannot reproduce this... Does it only happen to calls with prefix and suffix?!

@AndreasK79
Copy link
Contributor

It seems to happen with prefix. It was with the call LA/SP7VC where I noticed this behavior.

@AndreasK79
Copy link
Contributor

I'll make a separate issue on this.

@phl0
Copy link
Contributor Author

phl0 commented Oct 26, 2022

Oh right. QSL on the issue with prefixed callsigns. As such not an issue of this PR. So got for merge here imho.

@AndreasK79
Copy link
Contributor

As mentioned above, it has nothing to do with this PR. I should have made a separate issue when I found it.
Go for merge :)

@magicbug magicbug merged commit 61bc890 into magicbug:dev Oct 26, 2022
@phl0 phl0 deleted the moreQsoButton branch November 10, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants