[Logbookadvanced] First version of a logbook with filtering and batch processing of QSL handling. #1847

AndreasK79 · 2022-12-18T16:00:38Z

Thanks to @hugosilvaparagramanet for his QSL Manger PR. I took his code, modified and expanded the functionality. It was very interesting to see how things were solved, and I learned several new tricks.

I've renamed it to Logbook Advanced. For now, I've replaced the logbook link with this one.

Some changes from the original PR.

Renamed it to Logbook Advanced.
Datatable is added to the table for a scrollable body.
Added a lot more filtering (dxcc, iota, gridsquare, state, and propagation mode).
Built the functionality behind the buttons.

This is basically a logbook with filtering and batch processing of QSL handling.

Feedback is very welcome.

A preview:

I've added database save for updated info from callbook, if this info does not exist in the database.
Might need to dig some more about what info is returned from QRZ or HamQTH,

…processing of QSL handling.

phl0 · 2022-12-18T16:21:32Z

Is it intended that pressing "reset" does only reset the input form and does not update the table, i.e. return to the list of all QSOs?

AndreasK79 · 2022-12-18T16:25:39Z

That's how it's made, but can be changed.

phl0 · 2022-12-18T17:07:45Z

That's how it's made, but can be changed.

Ah ok. No worries. Thought it might be a bug. But WAD is OK also :)

AndreasK79 · 2022-12-18T18:56:04Z

@phl0 refresh and try the reset now :)

hugosilvaparagramanet · 2022-12-18T19:42:57Z

@AndreasK79 this looks really nice, I'm a little short on time but I'll do my best to try this changes

AndreasK79 · 2022-12-18T19:53:01Z

@hugosilvaparagramanet hope you like it. Thanks for the code and the idea.

…er executing batch job

AndreasK79 · 2022-12-21T08:11:58Z

@magicbug I think this is pretty close to ready, if not ready for merge. The question is, if this should have it's own menu item.

phl0 · 2022-12-21T13:29:59Z

If I may comment on this ... ;-) I would like to keep the old view as well. What do you think about this:

AndreasK79 · 2022-12-21T13:33:51Z

@phl0 good idea. I was thinking something like that myself.

phl0 · 2022-12-21T13:34:39Z

@phl0 good idea. I was thinking something like that myself.

QRX I will push that to a branch.

phl0 · 2022-12-21T13:38:30Z

The stuff is here: https://github.com/phl0/Cloudlog/commits/2logbooks. If @magicbug also agrees I can PR that to @AndreasK79's branch.

magicbug · 2022-12-21T13:53:03Z

Agree think we need to keep both for now at least

phl0 · 2022-12-21T13:54:28Z

Agree think we need to keep both for now at least

So https://github.com/AndreasK79/Cloudlog/pull/17 ;-)

Have two separate items for logbook and advanced

AndreasK79 · 2022-12-21T13:58:44Z

So... mergetime?

magicbug · 2022-12-21T13:59:07Z

think so! at least to dev branch for moar testing! :)

magicbug · 2022-12-21T14:08:33Z

Interesting, i'm guessing older mysql issue on my live setup i'm getting An error ocurred while making the request then loading it and its calling logbookadvanced/search

AndreasK79 · 2022-12-21T14:12:17Z

Hmm, check dev tools and see if you can pinpoint the error there.

magicbug · 2022-12-21T14:12:48Z

ERROR - 2022-12-21 14:10:43 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12

magicbug · 2022-12-21T14:15:25Z

ERROR - 2022-12-21 14:03:25 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:03:55 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:04:10 --> Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 7 - Invalid query:
SELECT *
FROM TABLE_HRD_CONTACTS_V01 qsos
INNER JOIN station_profile ON qsos.station_id=station_profile.station_id
WHERE station_profile.user_id = 5

		ORDER BY qsos.COL_TIME_ON desc
		LIMIT

ERROR - 2022-12-21 14:04:10 --> Severity: error --> Exception: Call to a member function result() on bool /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/application/models/Logbookadvanced_model.php 135
ERROR - 2022-12-21 14:04:59 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:05:36 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:05:54 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:06:55 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12
ERROR - 2022-12-21 14:07:05 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /home/twom0sql/domains/logbooks.2e0sql.co.uk/public_html/2m0sql/src/QSLManager/QSO.php 12

magicbug · 2022-12-21T14:15:51Z

Looks like i was right MySQL server version for the right syntax to use near '' at line 7 - Invalid query:

AndreasK79 · 2022-12-21T14:21:41Z

Not really sure that is the problem. The queries doesn't use anything special or newer functions.
It might be how the query is built together.

Try to set limit 250 on line 130 in logbookmodel_advanced.php.

magicbug · 2022-12-21T14:22:43Z

Ignore.. changed to PHP8 and it fixed it.

magicbug · 2022-12-21T14:23:10Z

This server which only hosts me needs an upgrade

AndreasK79 · 2022-12-21T14:23:18Z

What version were you running? I'm on 7.4.8 here.

magicbug · 2022-12-21T14:23:37Z

it was 7.3!

AndreasK79 · 2022-12-21T14:24:49Z

Right. Should we make sure it works on that version and older? If so, I need to set up a test machine.

magicbug · 2022-12-21T14:28:04Z

Maybe but I think perhaps not, just support the last "stable" release its fine on 7.4

oe7drt · 2022-12-28T22:58:44Z

Hi just found this via search and wanted to let you know that the advanced logbook failed on PHP 7.2.24 on Rocky Linux.

ERROR - 2022-12-28 22:32:49 --> Severity: error --> Exception: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) /opt/Cloudlog/src/QSLManager/QSO.php 12

I haven't tried with 7.3 as you all seem to use 7.4 and I can confirm it works now. Wasn't sure because the README only shows PHP 7. (7.4.30)

DL3EL · 2023-01-01T18:05:41Z

I am currently running PHP 7.4.33, all I get is "An error ocurred while making the request"... any tip?

AndreasK79 · 2023-01-01T18:49:15Z

@DL3EL I'm not sure what the lowest 7.4 is. I'm running 7.4.8 on my dev-setup, and it works fine here, so if you can upgrade the version a little bit and try again, that should fix it.

DL3EL · 2023-01-01T19:01:36Z

@AndreasK79 hmm.. I would think, that 7.4.33 is newer than 7.4.8

AndreasK79 · 2023-01-01T19:02:46Z

Oops. It should. Can you look in dev tools and see if you see any errors?

DL3EL · 2023-01-01T21:20:50Z

First I called Logbook Overview (1st and 2nd msg)
Then Logbook Advanced (3rd)
after that I filled the "De" Field and pressed "Search" (4th)

1st: DevTools failed to load source map: Could not load content for http://192.168.241.99/assets/css/bootstrap-dialog.css.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

2nd: DevTools failed to load source map: Could not load content for http://192.168.241.99/assets/js/bundle.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

3rd: jquery-3.3.1.min.js:2 POST http://192.168.241.99/index.php/logbookadvanced/search 500 (Internal Server Error)
send @ jquery-3.3.1.min.js:2
ajax @ jquery-3.3.1.min.js:2
(anonymous) @ logbookadvanced.js?1672500601:142
dispatch @ jquery-3.3.1.min.js:2
y.handle @ jquery-3.3.1.min.js:2
trigger @ jquery-3.3.1.min.js:2
(anonymous) @ jquery-3.3.1.min.js:2
each @ jquery-3.3.1.min.js:2
each @ jquery-3.3.1.min.js:2
trigger @ jquery-3.3.1.min.js:2
w.fn. @ jquery-3.3.1.min.js:2
(anonymous) @ logbookadvanced.js?1672500601:359
l @ jquery-3.3.1.min.js:2
c @ jquery-3.3.1.min.js:2
setTimeout (async)
(anonymous) @ jquery-3.3.1.min.js:2
u @ jquery-3.3.1.min.js:2
fireWith @ jquery-3.3.1.min.js:2
fire @ jquery-3.3.1.min.js:2
u @ jquery-3.3.1.min.js:2
fireWith @ jquery-3.3.1.min.js:2
ready @ jquery-3.3.1.min.js:2
_ @ jquery-3.3.1.min.js:2

4th: jquery-3.3.1.min.js:2 POST http://192.168.241.99/index.php/logbookadvanced/search 500 (Internal Server Error)
send @ jquery-3.3.1.min.js:2
ajax @ jquery-3.3.1.min.js:2
(anonymous) @ logbookadvanced.js?1672500601:142
dispatch @ jquery-3.3.1.min.js:2
y.handle @ jquery-3.3.1.min.js:2

AndreasK79 · 2023-01-01T21:23:47Z

Can you click on the logbookadvanced/search link and see if the error 500 has any more info?

DL3EL · 2023-01-01T21:48:09Z

is there an easy way to copy the whole stuff? Export to a .har file?

AndreasK79 · 2023-01-02T06:47:11Z

You need to click on the search call:

Then click on response on the right side. You will probably find an error there. That's the one I need to hopefully be able to pinpoint the problem.

DL3EL · 2023-01-02T08:27:37Z

hope that helps

AndreasK79 · 2023-01-02T08:29:35Z

I need what is under the response link.

DL3EL · 2023-01-02T09:34:48Z

I thought, that was not so important :-)

phl0 · 2023-01-02T09:36:22Z

Maybe set the environment to "development" in index.php temporarily to gain more info in the error.

DL3EL · 2023-01-03T11:17:00Z

Finally, with the help of @phl0 we could solve the issue. The root cause was, the upgrade to php 7.4 was only done on the OS level. Apache itsself was still running with php 7.3. Here is, what we did, the server is a Raspberry PI with Buster:

For better debug we enabled developer mode (index.php) and increase error level (application/config/config.php)
Install php 7.4 for OS

Make sure libapache2-mod-php7.4 is installed for Apache 2 module (root cause)
Check Admin/Debug Information, it should read "PHP Version 7.4.33"

If not, install it: "sudo apt install php7.4-json php7.4-curl php7.4-mbstring php7.4-mysql php7.4-zip php7.4-xml libapache2-mod-php7.4"
remove old php version: “sudo a2dismod php7.x”
(use “sudo a2dismod” to see exact name)
Enable new version: "sudo a2enmod php7.4”
Restart Apache “sudo systemctl restart apache2”

now the advance Logbook works like charme

AndreasK79 · 2023-01-03T11:24:19Z

That is great news! Glad it's now working. Good we have a Linux expert with @phl0 here.

[Logbookadvanced] First version of a logbook with filtering and batch…

dbc8a54

…processing of QSL handling.

AndreasK79 added 2 commits December 18, 2022 19:50

[Logbookadvanced] Added a few more columns

6cd742b

[Logbookadvanced] Reset now resets form and does initial search.

067196e

AndreasK79 added 5 commits December 19, 2022 18:20

[Logbookadvanced] Added dropdown to choose number of results returned

26cc67a

[Logbookadvanced] Improved layout on different resolutions

6ca8bb1

[Logbookadvanced] Saves callsign callbook info in database

5240164

[Logbookadvanced] Fixed so that master checkbox is also unchecked aft…

1b57e55

…er executing batch job

[Logbookadvanced] Fixed callsign link when updating row

d10a105

[Logbookadvanced] Search fix for SAT

be871d3

Have two separate items for logbook and advanced

a8987d1

Merge pull request #17 from phl0/2logbooks

fc8d631

Have two separate items for logbook and advanced

magicbug merged commit 507adce into magicbug:dev Dec 21, 2022

AndreasK79 deleted the logbookadvanced branch January 27, 2023 09:22

[Logbookadvanced] First version of a logbook with filtering and batch processing of QSL handling. #1847

[Logbookadvanced] First version of a logbook with filtering and batch processing of QSL handling. #1847

Conversation

AndreasK79 commented Dec 18, 2022 • edited Loading

phl0 commented Dec 18, 2022

AndreasK79 commented Dec 18, 2022

phl0 commented Dec 18, 2022

AndreasK79 commented Dec 18, 2022

hugosilvaparagramanet commented Dec 18, 2022

AndreasK79 commented Dec 18, 2022

AndreasK79 commented Dec 21, 2022

phl0 commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

phl0 commented Dec 21, 2022

phl0 commented Dec 21, 2022 • edited Loading

magicbug commented Dec 21, 2022

phl0 commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

magicbug commented Dec 21, 2022

magicbug commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

magicbug commented Dec 21, 2022

magicbug commented Dec 21, 2022

magicbug commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

magicbug commented Dec 21, 2022

magicbug commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

magicbug commented Dec 21, 2022

AndreasK79 commented Dec 21, 2022

magicbug commented Dec 21, 2022

oe7drt commented Dec 28, 2022 • edited Loading

DL3EL commented Jan 1, 2023

AndreasK79 commented Jan 1, 2023

DL3EL commented Jan 1, 2023

AndreasK79 commented Jan 1, 2023

DL3EL commented Jan 1, 2023

AndreasK79 commented Jan 1, 2023

DL3EL commented Jan 1, 2023

AndreasK79 commented Jan 2, 2023

DL3EL commented Jan 2, 2023

AndreasK79 commented Jan 2, 2023

DL3EL commented Jan 2, 2023

phl0 commented Jan 2, 2023

DL3EL commented Jan 3, 2023

AndreasK79 commented Jan 3, 2023

AndreasK79 commented Dec 18, 2022 •

edited

Loading

phl0 commented Dec 21, 2022 •

edited

Loading

oe7drt commented Dec 28, 2022 •

edited

Loading