[DXCC identification] This identifies when DXCC comes last #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phl0
approved these changes
Dec 28, 2022
|
This patch looks good to me. Tested with a hand full of callsigns with DXCC prefix and suffix. All worked fine. |
|
I've pulled this PR out for now as it completely breaks /P and also seems to assign wrong DXCCs to prefixes |
|
Isn't the point of a dev branch to fix the things, not just revert? I didn't have time to look into it before you reverted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue when prefix comes last, like N1MM/VP9.
DJ5CW wrote a PERL script for identifying a DXCC. I converted it to PHP. This is part of that conversion, which is now adapted to Cloudlog.
We can never 100% identify a DXCC, but this should help improve the identification.