Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DXCC identification] Fix for prefix coming last #1884

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[DXCC identification] Fix for prefix coming last #1884

merged 1 commit into from
Jan 3, 2023

Conversation

AndreasK79
Copy link
Contributor

Identified the trouble with the last PR.

I think I've fixed the cases that were wrong now.

@phl0
Copy link
Contributor

phl0 commented Dec 30, 2022

I have tested the rewritten/corrected implementation yesterday. All my test cases went OK.

@AndreasK79
Copy link
Contributor Author

Yes, @phl0 and I tested this one a lot yesterday.
Regex needed to be adjusted so that portable was identified correctly.
A variable was also needed to be adjusted to that SQ1 was identified correctly as well.

@AndreasK79 AndreasK79 merged commit bda9d3b into magicbug:dev Jan 3, 2023
@phl0 phl0 mentioned this pull request Jan 19, 2023
@AndreasK79 AndreasK79 deleted the dxcc_identification branch January 27, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants