Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra comma causing error #3009

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

PartTimeLegend
Copy link
Contributor

No description provided.

@magicbug
Copy link
Owner

magicbug commented Mar 13, 2024

Out of interest what error is this triggering?

Also set the base for the PR to dev as per readme PRs are not accepted against master.

@magicbug magicbug changed the base branch from master to dev March 13, 2024 16:23
@PartTimeLegend
Copy link
Contributor Author

Updated base branch. I thought I had set it to dev so that's my fault.

When the trailing comma is there on PHP 7.4 I get an unexpected ) error. Removing the comma resolved that. Might just be my server though.

@magicbug
Copy link
Owner

Interesting dont see that happening here but should be removed :D

@magicbug magicbug merged commit e348de2 into magicbug:dev Mar 13, 2024
@PartTimeLegend PartTimeLegend deleted the patch-1 branch March 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants