Contest "copy exchange to" #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohkay, so I could contribute code to disable/enable the "copy to"-select, depending on the exchange type, which leads to conflicts with other PR's I handed in. So I guess I'll wait until the PR's are merged :). Please let me know, if you prefer another approach. |
- in contest-session, the (numeric-)id of the selected 'copy' is saved, compatible with the previous DOK-copy. - UI changes - Logbook_model enhancements - Translation additions
|
Implementation looks good, happy for this to be merged 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contest-logging, Cloudlog featured copying the received exchange into the (rather specific) DARC DOK field.
This PR brings this valuable approach to a broader set of contests by implementing 'copy exchange to'
which could easily be enhanced for other needs (I just included those, I know about).
Some notes:
models/Logbook_model.php, an example for a more sophisticated copy is includedAs always, although not mentioning it everytime :), I'm open to discussions, wishes, enhancements, ...