Dockerize for development #3038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlog into dockerize-for-development
Merged
|
I think it safe to close this as its implemented within the end to end testing? |
|
Closing this one since these changes were in the PR for end to end testing here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces Docker support to the project, updates the
README.mdfile with Docker setup instructions, and modifies the project's environment variables. The key changes include adding a Dockerfile and a docker-compose file, updating the.env.samplefile with new environment variables, and modifying theREADME.mdfile to include Docker setup instructions and minor formatting changes.Environment Variables:
.env.sample: Added new environment variables for MySQL configuration, PHP settings, and Docker settings.Docker Support:
Dockerfile: Created a new Dockerfile to set up PHP and Apache in a Docker container, install system dependencies, and expose port 80.docker-compose.yml: Added a new docker-compose file to define and run multi-container Docker applications.README Updates:
README.md: Included Docker setup instructions and made minor formatting changes. The Docker instructions include prerequisites, configuration steps, and how to start the development environment.