Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect TypeScript project references and update READMEs with changelog links #151

Merged
merged 1 commit into from
Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
3 changes: 2 additions & 1 deletion packages/commons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
> Exposes a listing of common public APIs from `@magic-sdk/provider` and `@magic-sdk/typings` to the platform-specific entry points (`magic-sdk` and `@magic-sdk/react-native`)

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/public/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/commons/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/commons/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
1 change: 1 addition & 0 deletions packages/provider/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/provider/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/provider/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/react-native/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/react-native/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
1 change: 1 addition & 0 deletions packages/types/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/types/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/types/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
1 change: 1 addition & 0 deletions packages/web/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<p align="center">
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/web/LICENSE">License</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/packages/web/CHANGELOG.md">Changelog</a> ·
<a href="https://github.com/magiclabs/magic-js/blob/master/CONTRIBUTING.md">Contributing Guide</a>
</p>

Expand Down
6 changes: 3 additions & 3 deletions scripts/build.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

echo
boxen --border-color cyan --dim-border --padding 1 "🏗 Building TypeScripts..."
boxen --border-color cyan --dim-border --padding 1 "Building TypeScripts..."
echo

tsconfig_paths=$(echo -e $(yarn --silent paths tsconfig.json tsconfig.module.json))
Expand All @@ -16,7 +16,7 @@ echo "TypeScripts compiled."
# ---------------------------------------------------------------------------- #

echo
boxen --border-color cyan --dim-border --padding 1 "📦 Building CDN bundles..."
boxen --border-color cyan --dim-border --padding 1 "Building CDN bundles..."
echo

echo "You can safely ignore \`The 'this' keyword is equivalent to 'undefined'\` warnings"
Expand All @@ -27,7 +27,7 @@ yarn wsrun --serial $INIT_CWD/scripts/wsrun/build:cdn.sh
# ---------------------------------------------------------------------------- #

echo
boxen --border-color cyan --dim-border --padding 1 "🔗 Interpolating ENV variables..."
boxen --border-color cyan --dim-border --padding 1 "Interpolating ENV variables..."
echo

pkg_paths=$(echo -e $(yarn --silent paths))
Expand Down
2 changes: 1 addition & 1 deletion scripts/clean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ fi

msg() {
echo
boxen --border-color cyan --dim-border --padding 1 "🧼 Cleaning $1..."
boxen --border-color cyan --dim-border --padding 1 "Cleaning $1..."
echo
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/dev.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

echo
boxen --border-color cyan --dim-border --padding 1 "🏗 Building for development..."
boxen --border-color cyan --dim-border --padding 1 "Building for development..."
echo

pkg_paths=$(echo -e $(yarn --silent paths))
Expand Down
2 changes: 1 addition & 1 deletion scripts/lint.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

echo
boxen --border-color cyan --dim-border --padding 1 "🔎 Linting TypeScripts..."
boxen --border-color cyan --dim-border --padding 1 "Linting TypeScripts..."
echo

yarn wsrun --stages eslint --fix "**/src/**/*.ts"
2 changes: 1 addition & 1 deletion scripts/test.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

echo
boxen --border-color cyan --dim-border --padding 1 "🚦 Running tests..."
boxen --border-color cyan --dim-border --padding 1 "Running tests..."
echo

yarn wsrun --serial $INIT_CWD/scripts/wsrun/test:unit.sh $@
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
{ "path": "./packages/provider/tsconfig.json" },
{ "path": "./packages/provider/tsconfig.module.json" },

{ "path": "./packages/public/tsconfig.json" },
{ "path": "./packages/public/tsconfig.module.json" },
{ "path": "./packages/commons/tsconfig.json" },
{ "path": "./packages/commons/tsconfig.module.json" },

{ "path": "./packages/react-native/tsconfig.json" },
{ "path": "./packages/react-native/tsconfig.module.json" },
Expand Down