Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ES6 Proxy references #154

Merged
merged 8 commits into from
Dec 2, 2020
Merged

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Dec 1, 2020

📦 Pull Request

Our usage of ES6 Proxy was breaking support for legacy browsers like IE11. This is a small refactor to remove references to Proxy.

🚨 Test instructions

yarn test, as usual!

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@smithki smithki added the patch Increment the patch version when merged label Dec 1, 2020
@smithki smithki requested a review from Ethella December 1, 2020 21:56
@smithki smithki self-assigned this Dec 1, 2020
@smithki smithki force-pushed the smithki-remove-es6-proxy-reference branch from bba1614 to 141fcc6 Compare December 1, 2020 21:58
Dizigen
Dizigen previously approved these changes Dec 1, 2020
@smithki smithki requested a review from Dizigen December 2, 2020 03:14
@smithki smithki merged commit 62e3afe into master Dec 2, 2020
@smithki smithki deleted the smithki-remove-es6-proxy-reference branch December 2, 2020 03:30
@smithki
Copy link
Contributor Author

smithki commented Dec 2, 2020

🚀 PR was released in @magic-sdk/provider@4.0.2, @magic-sdk/react-native@4.0.2, magic-sdk@4.0.2 🚀

@smithki smithki added the released This issue/pull request has been released. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants