Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SemVer cyclic dependency issues with some hacks #209

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Fix SemVer cyclic dependency issues with some hacks #209

merged 4 commits into from
Sep 14, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Sep 14, 2021

Fix issues affecting our usage of semver by pre-bundling it and manually fixing the cyclic references.

@smithki smithki added the patch Increment the patch version when merged label Sep 14, 2021
@smithki smithki merged commit d954954 into master Sep 14, 2021
@smithki smithki deleted the fix/semver branch September 14, 2021 19:17
@smithki smithki added released This issue/pull request has been released. prerelease This change is available in a prerelease. labels Sep 14, 2021
@smithki
Copy link
Contributor Author

smithki commented Sep 17, 2021

🚀 PR was released in @magic-sdk/commons@3.0.0-dgerrells-ch42053-sms-feature.0, @magic-sdk/provider@7.0.0-dgerrells-ch42053-sms-feature.0, @magic-sdk/react-native@7.0.0-dgerrells-ch42053-sms-feature.0, @magic-sdk/types@6.0.0-dgerrells-ch42053-sms-feature.0, magic-sdk@7.0.0-dgerrells-ch42053-sms-feature.0 🚀

@magiclabs magiclabs deleted a comment from shortcut-integration bot Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smithki