Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use '.mjs' extension for ESM build files #230

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Use '.mjs' extension for ESM build files #230

merged 2 commits into from
Oct 20, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Oct 20, 2021

📦 Pull Request

An issue was occurring when compiling magic-sdk into Svelte projects using @sveltejs/adapter-node, which is apparently not inferring package.json#exports#import as ES modules correctly without an explicit .mjs extension.

✅ Fixed Issues

@smithki smithki added the patch Increment the patch version when merged label Oct 20, 2021
@smithki smithki self-assigned this Oct 20, 2021
@smithki smithki merged commit 4c90e0f into master Oct 20, 2021
@smithki smithki deleted the fix/svelte-adapter-node-imports-broken branch October 20, 2021 18:29
@smithki
Copy link
Contributor Author

smithki commented Oct 20, 2021

🚀 PR was released in @magic-ext/oauth@0.10.2, @magic-ext/react-native-oauth@0.5.2, @magic-ext/webauthn@0.2.2, @magic-sdk/commons@2.1.2, @magic-sdk/pnp@0.3.1, @magic-sdk/provider@6.1.2, @magic-sdk/react-native@6.1.2, @magic-sdk/types@5.1.2, magic-sdk@6.1.2 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 20, 2021
@smithki smithki mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithki smithki

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6.1.1 Throws during build or preview tasks when used with Svelte-Kit
1 participant
@smithki