Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'semver' re-export from '@magic-sdk/provider' utils #237

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Remove 'semver' re-export from '@magic-sdk/provider' utils #237

merged 1 commit into from
Nov 8, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Nov 2, 2021

📦 Pull Request

Removes the (unnecessary) export * as semver from './semver' statement in @magic-sdk/provider/src/utils/index.ts.

✅ Fixed Issues

@smithki smithki self-assigned this Nov 2, 2021
@smithki smithki added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Nov 2, 2021
@smithki smithki merged commit 4f2419b into master Nov 8, 2021
@smithki smithki deleted the fix/semver-type-error branch November 8, 2021 19:39
@smithki smithki removed the skip-release Preserve the current version when merged label Nov 8, 2021
@smithki
Copy link
Contributor Author

smithki commented Nov 8, 2021

🚀 PR was released in @magic-ext/bitcoin@1.0.1, @magic-ext/oauth@0.11.1, @magic-ext/react-native-oauth@0.6.1, @magic-ext/webauthn@0.3.1, @magic-sdk/commons@2.2.1, @magic-sdk/pnp@0.5.1, @magic-sdk/provider@6.2.1, @magic-sdk/react-native@6.2.1, magic-sdk@6.2.1 🚀

@smithki smithki added the released This issue/pull request has been released. label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithki smithki

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6.2 versions fail on build with typescript / missing semver in type declarations.
1 participant
@smithki