Bare React Native / Expo React Native Package Split #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #52891: Decouple Expo from RN to support bare RN. |
Ariflo
force-pushed
the
ariflo-sc-52891-rn-expo-split-master
branch
3 times, most recently
from
cd1034d to
06ba92d
Compare
Ariflo
changed the title
Ariflo
force-pushed
the
ariflo-sc-52891-rn-expo-split-master
branch
from
06ba92d to
5940f1d
Compare
|
Any update on this? This is an important change, we need separate packages for expo and bare RN. |
Ariflo
force-pushed
the
ariflo-sc-52891-rn-expo-split-master
branch
from
5940f1d to
75ef4d5
Compare
@kawee-akru we're working on getting this released before the end of the week. Thank you for your patience 🙇 |
Ariflo
force-pushed
the
ariflo-sc-52891-rn-expo-split-master
branch
from
a5bcd4e to
22460a0
Compare
Ariflo
added
minor
Ethella
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
This PR effectively splits the
@magic-sdk/react-nativeSDK into@magic-sdk/react-native-expoand@magic-sdk/react-native-bare. This also includes the splitting of@magic-ext/react-native-oauthalong the same lines (ie.@magic-ext/react-native-bare-oauthand@magic-ext/react-native-expo-oauth✅ Fixed Issues
This will generally resolve issues for devs utilizing a Bare RN vs Expo setup with our SDK
🚨 Test instructions
Best to utilize a sample app from this repo with the varying packages installed to test these changes.
NOTE
The
@magic-sdk/react-native-expoand@magic-sdk/react-native-bareare private and will remain so until this PR is merged.patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.