Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move connect methods to wallet module under magic-sdk #446

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Feb 6, 2023

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

Move connect methods (& re-named them) to new Wallet module under magic-sdk

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@hcote hcote added the minor Increment the minor version when merged label Feb 8, 2023
@hcote hcote marked this pull request as ready for review February 8, 2023 21:48
Copy link
Contributor

@Dizigen Dizigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM!

@hcote hcote merged commit 7f6dc86 into master Feb 9, 2023
@hcote hcote deleted the hcote-move-connect-methods-to-wallet-module branch February 9, 2023 22:55
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants