Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updatePhoneNumber sdk method #450

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Conversation

mushfichowdhury-magic
Copy link
Contributor

@mushfichowdhury-magic mushfichowdhury-magic commented Feb 13, 2023

📦 Pull Request

Added in .updatePhoneNumber method for sdk as per Clubhouse deliverable

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@mushfichowdhury-magic
Copy link
Contributor Author

@Ariflo I added a new sdk method for a Clubhouse deliverable, will there be any updates needed on the mobile end?

@Ariflo
Copy link
Contributor

Ariflo commented Feb 13, 2023

@Ariflo I added a new sdk method for a Clubhouse deliverable, will there be any updates needed on the mobile end?

Thanks for the heads up @mushfichowdhury-magic, yes this will need equivalent changes on our native iOS and Android SDK.

@mushfichowdhury-magic mushfichowdhury-magic changed the title Add updateSms sdk method Add updatePhoneNumber sdk method Feb 13, 2023
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR needs some yarn.lock updates.

@mushfichowdhury-magic
Copy link
Contributor Author

@Ariflo should be good to review!

@mushfichowdhury-magic mushfichowdhury-magic added minor Increment the minor version when merged ✨Feature Request and removed ✨Feature Request labels Feb 14, 2023
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mushfichowdhury-magic mushfichowdhury-magic merged commit 666de4d into master Feb 14, 2023
@mushfichowdhury-magic mushfichowdhury-magic deleted the mushfi/update-sms branch February 14, 2023 23:39
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants