Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [sc-71135] Add purchase SDK method #455

Merged
merged 18 commits into from
Mar 21, 2023
Merged

feat: [sc-71135] Add purchase SDK method #455

merged 18 commits into from
Mar 21, 2023

Conversation

bcleary06
Copy link
Contributor

@bcleary06 bcleary06 commented Feb 15, 2023 •
edited
Loading

📦 Pull Request

Adding NFT Purchase SDK method

🚨 Test instructions

This can be tested via /e2e

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #71135: Add purchase SDK method.

@bcleary06 bcleary06 added the patch Increment the patch version when merged label Mar 20, 2023
@bcleary06 bcleary06 marked this pull request as ready for review March 20, 2023 22:43
@bcleary06 bcleary06 requested review from hcote, Ariflo and mattupham March 20, 2023 22:44
Ariflo
Ariflo previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, short of the test fail.

Ariflo
Ariflo approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, assuming tests pass.

@bcleary06 bcleary06 merged commit 3b7a9e3 into master Mar 21, 2023
@bcleary06 bcleary06 deleted the briancleary7114-sc-71135-add-checkout-sdk-method branch March 21, 2023 03:46
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/algorand@8.6.2, @magic-ext/avalanche@8.6.2, @magic-ext/bitcoin@8.6.2, @magic-ext/conflux@6.6.2, @magic-ext/connect@6.7.2, @magic-ext/cosmos@8.6.2, @magic-ext/ed25519@4.6.2, @magic-ext/flow@8.7.2, @magic-ext/harmony@8.6.2, @magic-ext/icon@8.6.2, @magic-ext/near@8.6.2, @magic-ext/oauth@7.6.2, @magic-ext/polkadot@8.6.2, @magic-ext/react-native-bare-oauth@8.6.2, @magic-ext/react-native-expo-oauth@8.7.2, @magic-ext/solana@9.6.2, @magic-ext/taquito@5.6.2, @magic-ext/terra@5.6.2, @magic-ext/tezos@8.6.2, @magic-ext/webauthn@7.6.2, @magic-ext/zilliqa@8.6.2, @magic-sdk/commons@9.6.2, @magic-sdk/pnp@7.6.2, @magic-sdk/provider@13.6.2, @magic-sdk/react-native-bare@14.6.2, @magic-sdk/react-native-expo@14.6.2, @magic-sdk/types@11.6.2, magic-sdk@13.6.2 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

@hcote hcote Awaiting requested review from hcote

@mattupham mattupham Awaiting requested review from mattupham

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcleary06 @magiclabsFE @Ariflo @hcote