-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* Add recoverAccount api #458
Merged
Ethella
merged 5 commits into
master
from
jerryliu-sc-71407-add-recoveraccount-in-magic-js
Feb 21, 2023
Merged
* Add recoverAccount api #458
Ethella
merged 5 commits into
master
from
jerryliu-sc-71407-add-recoveraccount-in-magic-js
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #71407: add recoverAccount in magic-js. |
@@ -85,4 +86,13 @@ export class UserModule extends BaseModule { | |||
); | |||
return this.request<string | null>(requestPayload); | |||
} | |||
|
|||
/** */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: remove empty comment
dgerrellsMagic
previously approved these changes
Feb 17, 2023
mushfichowdhury-magic
previously approved these changes
Feb 17, 2023
Ethella
dismissed stale reviews from mushfichowdhury-magic and dgerrellsMagic
via
February 17, 2023 04:19
df51c78
mushfichowdhury-magic
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
[Provide a general summary of the pull request here.]
Add
recoverAccount({email})
β Fixed Issues
π¨ Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.