Fix RedisClient not getting closed on connection failure

magicmq · Jun 1, 2024 · b4a77c3 · b4a77c3
1 parent bd3346e
commit b4a77c3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/main/java/dev/magicmq/pyspigot/manager/redis/RedisManager.java b/src/main/java/dev/magicmq/pyspigot/manager/redis/RedisManager.java
@@ -22,6 +22,7 @@
 import dev.magicmq.pyspigot.manager.script.Script;
 import dev.magicmq.pyspigot.util.ScriptUtils;
 import io.lettuce.core.ClientOptions;
+import io.lettuce.core.RedisConnectionException;
 import io.lettuce.core.RedisURI;
 
 import java.util.ArrayList;
@@ -135,11 +136,14 @@ public ScriptRedisClient openRedisClient(ClientType clientType, RedisURI redisUR
         else /*if (clientType == ClientType.PUB_SUB)*/
             client = new RedisPubSubClient(script, redisURI, clientOptions);
 
-        if (client.open()) {
+        try {
+            client.open();
             addClient(client);
             return client;
-        } else
-            throw new RuntimeException("Failed to open a connection to the redis server.");
+        } catch (RedisConnectionException e) {
+            client.close();
+            throw e;
+        }
     }
 
     /**