Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes & 1 second sensors #301

Closed
wants to merge 5 commits into from
Closed

Conversation

timlaing
Copy link
Contributor

@timlaing timlaing commented Aug 9, 2024

  • Added OptionsFlow to allow user selection of sensors required
  • Added back 1 seconds sensors as I needed them for some automations
  • Fixed deprecation warnings from HA core

@magico13
Copy link
Owner

I've already fixed the warnings in my dev branch but I appreciate it nonetheless. The OptionsFlow stuff is really nice and has been on my TODO list for a while. Unfortunately I cannot support the one second sensor, it's explicitly forbidden by Emporia and I'd rather not anger them (again). For context, see this discussion in the PyEmVue repo. magico13/PyEmVue#19

@magico13
Copy link
Owner

If you need the resolution at one second I would recommend flashing ESPHome onto the Vue hardware to get fully local access. You can of course run your own fork with whatever you want enabled, but Emporia might ask you to stop or choose to cut off your access/rate limit you.

@timlaing
Copy link
Contributor Author

Thanks for your feedback. I'll submit a different pull request for the options flow code.

@timlaing timlaing closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants