Port codecov to use Codecov's Github Action dedicated wrapper #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate reason for doing this is that running codecov failed
with:
```
==> Uploading reports
/home/magjac/d3-graphviz/node_modules/codecov/lib/codecov.js:217
} else if (result.split('\n').length !== 2) {
^
TypeError: result.split is not a function
at /home/magjac/d3-graphviz/node_modules/codecov/lib/codecov.js:217:25
at /home/magjac/d3-graphviz/node_modules/teeny-request/build/src/index.js:217:17
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.19.1
```
The Codecov NodeJS Uploader¹ has been deprecated and seems to no
longer work. Instead, uploading reports to Codecov using the Codecov
CLI² is now recommeded. This change does this using the Codecov GitHub
Action³.
¹ https://github.com/codecov/codecov-node
² https://docs.codecov.com/docs/codecov-uploader
³ https://github.com/marketplace/actions/codecov
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 2283 2283
=========================================
Hits 2283 2283 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate reason for doing this is that running codecov failed with:
The Codecov NodeJS Uploader¹ has been deprecated and seems to no longer work. Instead, uploading reports to Codecov using the Codecov CLI² is now recommeded. This change does this using the Codecov GitHub Action³.
¹ https://github.com/codecov/codecov-node
² https://docs.codecov.com/docs/codecov-uploader
³ https://github.com/marketplace/actions/codecov