PHAR 3.3.0 has \r char that breaks tool under Linux

[Slamdunk]

See shivammathur/setup-php#473 (comment)

$ wget "https://github.com/maglnet/ComposerRequireChecker/releases/download/3.3.0/composer-require-checker.phar"
[...]
2021-07-12 11:17:18 (1.38 MB/s) - ‘composer-require-checker.phar’ saved [634200/634200]
$ chmod +x composer-require-checker.phar
$ ./composer-require-checker.phar
/usr/bin/env: ‘php\r’: No such file or directory

[Slamdunk]

Likely related to

ComposerRequireChecker/build.xml

Line 60 in a4a0380

<php expression="file_put_contents('bin/clistub.php', '#!/usr/bin/env php' . PHP_EOL . Phar::createDefaultStub('bin/composer-require-checker.php'))"/>

[loevgaard]

Obviously I don't know what people use for setting up their CI, but I use GitHub Actions and https://github.com/shivammathur/setup-php for setting up PHP. I have fixed this temporarily with this setup-php config:

dependency-analysis:
    name: "Dependency Analysis"

    runs-on: "ubuntu-latest"

    strategy:
        matrix:
            php-version:
                - "7.4"
                - "8.0"

            dependencies:
                - "highest"

    steps:
        -   name: "Checkout"
            uses: "actions/checkout@v2"

        -   name: "Setup PHP, with composer and extensions"
            uses: "shivammathur/setup-php@v2"
            with:
                coverage: "none"
                extensions: "${{ env.PHP_EXTENSIONS }}"
                php-version: "${{ matrix.php-version }}"
                tools: "composer-require-checker:3.1.0, composer-unused" # todo using 3.1.0 until this issue is fixed: https://github.com/maglnet/ComposerRequireChecker/issues/281

Notice the composer-require-checker:3.1.0 in the tools key.

[Ocramius]

As per #256, my recommendation on how to install the tool:

mkdir -p tools/composer-require-checker
cd tools/composer-require-checker
echo "{}" > composer.json
composer require maglnet/composer-require-checker
cd -
tools/composer-require-checker/vendor/bin/composer-require-checker

Committing a composer.lock inside tools/composer-require-checker is endorsed :)

[loevgaard]

I see your point, @Ocramius. Thanks :)

[Slamdunk]

As of today, even setup-php uses the composer installation method:

• shivammathur/setup-php@1a21663
• https://github.com/shivammathur/setup-php/releases/tag/2.12.0
• composer-require-checker: /usr/bin/env: ‘php\r’: No such file or directory shivammathur/setup-php#473 (comment)

[loevgaard]

Guess we all love Shivam ❤️

[mfn]

I understand the desire the remove phar building completely, bad it's damn convenient TBH.

And, maybe I'm wring, we just need to use a \n instead of PHP_EOL I thought I make a PR -> #310

I tested this locally and it just worked (though I'm on non-windows systems anyway 😬)

[Ocramius]

Handled in #310