suggest php as dependency if extension is one of the core-extensions

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## [unreleased]
 ### Added
 - add symbol counts to check command for verbose output
+- suggest `php` as extension if it's a core extension
 
 ### Changed
 

composer.json

@@ -35,7 +35,7 @@
     },
     "require-dev": {
         "phpunit/phpunit":    "^6.0",
-        "mikey179/vfsStream": "^1.6",
+        "mikey179/vfsstream": "^1.6",
         "phpstan/phpstan": "^0.10.3"
     },
     "config": {

src/ComposerRequireChecker/Cli/CheckCommand.php

@@ -114,7 +114,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $output->writeln("The following unknown symbols were found:");
         $table = new Table($output);
         $table->setHeaders(['unknown symbol', 'guessed dependency']);
-        $guesser = new DependencyGuesser();
+        $guesser = new DependencyGuesser($options);
         foreach ($unknownSymbols as $unknownSymbol) {
             $guessedDependencies = [];
             foreach ($guesser($unknownSymbol) as $guessedDependency) {

src/ComposerRequireChecker/Cli/Options.php

@@ -61,7 +61,7 @@ public function getSymbolWhitelist(): array
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getPhpCoreExtensions(): array
     {

src/ComposerRequireChecker/DependencyGuesser/DependencyGuesser.php

@@ -2,6 +2,8 @@
 
 namespace ComposerRequireChecker\DependencyGuesser;
 
+use ComposerRequireChecker\Cli\Options;
+
 class DependencyGuesser
 {
 
@@ -10,9 +12,9 @@ class DependencyGuesser
      */
     private $guessers = [];
 
-    public function __construct()
+    public function __construct(?Options $options = null)
     {
-        $this->guessers[] = new GuessFromLoadedExtensions();
+        $this->guessers[] = new GuessFromLoadedExtensions($options);
     }
 
     public function __invoke($symbolName): \Generator

src/ComposerRequireChecker/DependencyGuesser/GuessFromLoadedExtensions.php

@@ -2,15 +2,24 @@
 
 namespace ComposerRequireChecker\DependencyGuesser;
 
+use ComposerRequireChecker\Cli\Options;
 use ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromExtensions;
 
 class GuessFromLoadedExtensions implements GuesserInterface
 {
     private $loadedExtensions;
 
-    public function __construct()
+    /**
+     * @var string[]|null
+     */
+    private $coreExtensions;
+
+    public function __construct(?Options $options = null)
     {
         $this->loadedExtensions = get_loaded_extensions();
+        if ($options instanceof Options) {
+            $this->coreExtensions = $options->getPhpCoreExtensions();
+        }
     }
 
     public function __invoke(string $symbolName): \Generator
@@ -19,6 +28,10 @@ public function __invoke(string $symbolName): \Generator
         foreach ($this->loadedExtensions as $extensionName) {
             $extensionSymbols = $definedSymbolsFromExtensions([$extensionName]);
             if (in_array($symbolName, $extensionSymbols)) {
+                if ($this->coreExtensions && in_array($extensionName, $this->coreExtensions)) {
+                    yield 'php';
+                }
+
                 yield 'ext-' . $extensionName;
             }
         }

test/ComposerRequireCheckerTest/DependencyGuesser/DependencyGuesserTest.php

@@ -2,6 +2,7 @@
 
 namespace ComposerRequireCheckerTest\DependencyGuesser;
 
+use ComposerRequireChecker\Cli\Options;
 use ComposerRequireChecker\DependencyGuesser\DependencyGuesser;
 use PHPUnit\Framework\TestCase;
 
@@ -33,4 +34,13 @@ public function testDoesNotSuggestAnything()
         $result = $this->guesser->__invoke('an_hopefully_unique_unknown_symbol');
         $this->assertFalse($result->valid());
     }
+
+    public function testCoreExtensionsResolvesToPHP()
+    {
+        $options = new Options(['php-core-extensions' => ['SPL', 'something-else']]);
+        $this->guesser = new DependencyGuesser($options);
+        $result = $this->guesser->__invoke('RecursiveDirectoryIterator');
+        $this->assertNotEmpty($result);
+        $this->assertContains('php', $result);
+    }
 }