Add support of Symfony Console 5. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
commented
Dec 18, 2019
| @@ -45,6 +45,8 @@ public function enterNode(Node $node) | |||
| $this->recordFunctionDefinition($node); | |||
| $this->recordConstDefinition($node); | |||
| $this->recordDefinedConstDefinition($node); | |||
|
|
|||
| return $node; | |||
There was a problem hiding this comment.
PHPStan was complaining about no return because of method's signature in PhpParser lib. I don't know if I should return null or a Node
Ocramius
reviewed
Dec 19, 2019
Ocramius
approved these changes
Dec 19, 2019
|
Thanks! |
|
@Ocramius @ptondereau Why dropping support for symfony 4 when you added the support for symfony 5 ? You could have both. This is a breaking change, tagged as a minor update. |
|
Heya, Dependency upgrades are not BC breaks, as they move the dependency, not the API of the package. You can keep using the previous version, or install the tool standalone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just added support of symfony's console 5