Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding *number* of unknown symbols above output table #212

Closed
wants to merge 5 commits into from
Closed

Adding *number* of unknown symbols above output table #212

wants to merge 5 commits into from

Conversation

ThomasLandauer
Copy link
Contributor

Add number of errors above output table

@ThomasLandauer
Update CheckCommand.php
3d081e4 
Add number of errors above output table
Ocramius
Ocramius approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ocramius
Copy link
Collaborator

Tests require adjustments, but overall the improvement seems valid 👍

@Ocramius
Copy link
Collaborator

@ThomasLandauer could you adjust commit messages and issue description/title to explain what is being done, so that it comes out in the changelog in the end? :D

@ThomasLandauer ThomasLandauer changed the title Update CheckCommand.php Adding *number* of unknown symbols above output table Oct 27, 2020
@ThomasLandauer
Copy link
Contributor Author

Do you mean the commit messages at https://github.com/maglnet/ComposerRequireChecker/pull/212/commits ("Update CheckCommand.php", "Update BinaryTest.php", ...)? => Sorry, don't know how to change them :-(

But at least I managed to change the title :-)

@Ocramius
Copy link
Collaborator

@ThomasLandauer in your local environment, you can git rebase -i master, and then rename single commits :)

@ThomasLandauer
Copy link
Contributor Author

Sorry, I've done everything on github.com - no local environment :-(

@Ocramius
Copy link
Collaborator

Figured (by the default commit messages) - I'll get the adjustments done when merging 👍

@Ocramius Ocramius assigned Ocramius and unassigned ThomasLandauer Oct 27, 2020
@Ocramius Ocramius added this to the 3.0.0 milestone Oct 27, 2020
Ocramius added a commit that referenced this pull request Jan 18, 2021
@Ocramius
Test fixup: since #212 got sent, a new test was added to check CLI co…
c19b7f9 
…mmand output
Ocramius added a commit that referenced this pull request Jan 18, 2021
@Ocramius
Merge branch 'feature/#212-add-number-of-unknown-symbols-above-output…
de65f9a 
…-table'
@Ocramius
Copy link
Collaborator

Rebased and manually merged via de65f9a, thanks @ThomasLandauer!

@Ocramius Ocramius closed this Jan 18, 2021
@ThomasLandauer ThomasLandauer deleted the patch-1 branch January 18, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasLandauer @Ocramius