-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test automatic phar creation process #223
Conversation
- name: "build via phing" | ||
run: "phing" | ||
|
||
- name: "Upload phar file artifact" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this runs on: [pull_request, branch]
, where is this artifact to be found? Just attached to builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the phar is available and attached to the build, for this PR it would be here: https://github.com/maglnet/ComposerRequireChecker/actions/runs/368166959
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, but not really a stable distribution channel.
If this is only for testing, it should be fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes only for testing new features / bugfixes as a phar.
And as a nice on top: It's testing the phar building process itself - since it the phar now getting build for every PR :)
@Ocramius master is now removed as a build target |
Thanks @DanielBadura! |
With this PR we add the possibility to test new features via an automatic phar build created and download able from the CI. With this new stuff can be easy tested on larger projects and without checking out the branch and manually building the phar. WDYT?