Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test automatic phar creation process #223

Merged
merged 3 commits into from
Nov 27, 2020

Conversation

DanielBadura
Copy link
Contributor

@DanielBadura DanielBadura commented Nov 17, 2020

With this PR we add the possibility to test new features via an automatic phar build created and download able from the CI. With this new stuff can be easy tested on larger projects and without checking out the branch and manually building the phar. WDYT?

@DanielBadura DanielBadura marked this pull request as ready for review November 17, 2020 13:33
- name: "build via phing"
run: "phing"

- name: "Upload phar file artifact"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this runs on: [pull_request, branch], where is this artifact to be found? Just attached to builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the phar is available and attached to the build, for this PR it would be here: https://github.com/maglnet/ComposerRequireChecker/actions/runs/368166959

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but not really a stable distribution channel.

If this is only for testing, it should be fine 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes only for testing new features / bugfixes as a phar.
And as a nice on top: It's testing the phar building process itself - since it the phar now getting build for every PR :)

@Ocramius Ocramius added this to the 3.0.0 milestone Nov 27, 2020
@Ocramius Ocramius changed the title Automatic phar creation per PR Test automatic phar creation process Nov 27, 2020
@Ocramius Ocramius self-assigned this Nov 27, 2020
@DanielBadura
Copy link
Contributor Author

@Ocramius master is now removed as a build target

@Ocramius Ocramius merged commit 8d6324f into maglnet:master Nov 27, 2020
@Ocramius
Copy link
Collaborator

Thanks @DanielBadura!

@DanielBadura DanielBadura deleted the automatic-phar-build branch November 30, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants