Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic phar creation for releases #316

Merged
merged 9 commits into from
Nov 10, 2021
Merged

Conversation

maglnet
Copy link
Owner

@maglnet maglnet commented Nov 10, 2021

No description provided.

.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
.github/workflows/phar-creation.yml Outdated Show resolved Hide resolved
@maglnet maglnet force-pushed the feature/automatic-phar-release branch from 60a00fd to be047ce Compare November 10, 2021 10:28
@maglnet maglnet marked this pull request as ready for review November 10, 2021 11:01
@maglnet
Copy link
Owner Author

maglnet commented Nov 10, 2021

Does anyone know a good way to check github actions locally?

@DanielBadura
Copy link
Contributor

I saw this in my feed once: https://github.com/nektos/act
Never used it tho.

@Ocramius
Copy link
Collaborator

Yeah, act is the way :)

@maglnet
Copy link
Owner Author

maglnet commented Nov 10, 2021

Thanks for your input @DanielBadura @Ocramius

I'll try act next time instead of pushing over and over again :-)
Do you know if it's possible to test "releasing" and uploading?

If you don't see any further issues, I'll give this a first try for the next release and you may merge it @Ocramius ?

@Ocramius
Copy link
Collaborator

Do you know if it's possible to test "releasing" and uploading?

Not sure: it is potentially feasible to trigger act with a custom-crafted github event, but I'm no expert there.

I'll give this a first try for the next release and you may merge it @Ocramius ?

If you want, we can merge and trigger a release right now: wouldn't hurt.

@Ocramius Ocramius added this to the 3.5.0 milestone Nov 10, 2021
@DanielBadura
Copy link
Contributor

You could even release a beta release like 3.5.0-beta, no? So everyone knows something is getting tested in the release.

@maglnet
Copy link
Owner Author

maglnet commented Nov 10, 2021

I'm fine with both, beta and stable.
Let's go :-)

composer.json Outdated Show resolved Hide resolved
@Ocramius
Copy link
Collaborator

You could even release a beta release like 3.5.0-beta, no?

Not supported by release automation: 3.5.0 it is, and if it's borked, it will be 3.5.1 :-)

@Ocramius Ocramius self-assigned this Nov 10, 2021
@Ocramius Ocramius merged commit 1379c49 into 3.5.x Nov 10, 2021
@Ocramius Ocramius deleted the feature/automatic-phar-release branch November 10, 2021 11:54
@Ocramius
Copy link
Collaborator

Indeed, it failed :D

https://github.com/maglnet/ComposerRequireChecker/runs/4164758607?check_suite_focus=true

Please do make a new PR for 3.5.x and we'll get it fixed in 3.5.1

@maglnet
Copy link
Owner Author

maglnet commented Nov 10, 2021

Ahh, lol :-)

I need to run composer install first, otherwise there's no phing available now to execute the composer install :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants