-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --output=json
and --output=text
option to CLI, to allow for better automation/reporting based on STDOUT
#331
Merged
Ocramius
merged 4 commits into
maglnet:3.8.x
from
dkreuer:feature/different-output-formats
Dec 7, 2021
Merged
Add --output=json
and --output=text
option to CLI, to allow for better automation/reporting based on STDOUT
#331
Ocramius
merged 4 commits into
maglnet:3.8.x
from
dkreuer:feature/different-output-formats
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkreuer
force-pushed
the
feature/different-output-formats
branch
from
December 6, 2021 11:46
a9cf1e2
to
1bd9049
Compare
Ocramius
requested changes
Dec 7, 2021
dkreuer
force-pushed
the
feature/different-output-formats
branch
from
December 7, 2021 11:29
1bd9049
to
91414c2
Compare
Ocramius
requested changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes needed, but overall really close
dkreuer
force-pushed
the
feature/different-output-formats
branch
from
December 7, 2021 13:49
91414c2
to
3d4cd6f
Compare
Ocramius
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 thanks @dkreuer!
Ocramius
changed the title
Add report format json
Add Dec 7, 2021
--output=json
and --output=text
option to CLI, to allow for better automation/reporting based on STDOUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through open issues I saw #294 and thought, "hey let's write a quick implementation for that".
I abstracted writing the actual unknown symbols table and added a json report writer. Please have a look!
There will be a new cli option "--output=[format]" which allows to specify either "text" or "json". If specified, all other output will be suppressed except for the actual report (which is the unknown symbols table for "text" or the json report for "json").
If the option is omitted, no behavior change occurs (normal text output with all the fluff).
Fixes #294