-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json
to core extensions and minor improvements
#351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks good - ext-json
is indeed always baked in, unless someone really wants to disable ext-json
during PHP compilation
src/ComposerRequireChecker/DefinedExtensionsResolver/DefinedExtensionsResolver.php
Outdated
Show resolved
Hide resolved
Urgh, this again:
Can you run a local |
|
Seems, we don't can disable json: https://www.php.net/manual/en/configure.about.php |
@vjik could you squash out all fixup commits that aren't explicative? |
That's all. All problems fixed and CI actions pass. |
Ah, you didn't eliminate them :D
Because git history is not a dumping ground ;-) Anyway, I suggest that only 9eb100b survives |
Thanks @vjik! |
Fix #350