#354 Make sure language types are always in the symbol whitelist

[willemstuursma]

The language types should always be in the whitelist. Else, ComposerRequireChecker will give errors like:

The following 1 unknown symbols were found:
+----------------+--------------------+
| Unknown Symbol | Guessed Dependency |
+----------------+--------------------+
| mixed          |                    |
+----------------+--------------------+
Command exited with non-zero status 1

[Ocramius]

LGTM 👍

[Ocramius]

Some CS changes needed

[willemstuursma]

Some CS changes needed

Yes, I will take care of it.

[DanielBadura]

Should we also remove the whitelist part on the default config json to prevent confusion on this topic?

[Ocramius]

Can certainly be done 👍

[willemstuursma]

@DanielBadura @Ocramius Please let me know if this is satisfactory or feel free to merge.

[Ocramius]

There is one mutant to be fixed, indicating a missing test:

2) /home/runner/work/ComposerRequireChecker/ComposerRequireChecker/src/ComposerRequireChecker/Cli/Options.php:108    [M] UnwrapArrayUnique

--- Original
+++ New
@@ @@
          * Make sure the language types (e.g. 'true', 'false', 'object', 'mixed') are always included in the symbol
          * whitelist. If these are omitted the results can be pretty unexpected.
          */
-        $this->symbolWhitelist = array_unique(array_merge(self::PHP_LANGUAGE_TYPES, $symbolWhitelist));
+        $this->symbolWhitelist = array_merge(self::PHP_LANGUAGE_TYPES, $symbolWhitelist);
     }
     /**
      * @param array<string> $phpCoreExtensions

See https://github.com/maglnet/ComposerRequireChecker/runs/8087054988?check_suite_focus=true#step:9:74

[willemstuursma]

Cheers, I added an assertion that should fix it

[Ocramius]

Thanks @willemstuursma!