Allow php 8.3 #410
Allow php 8.3 #410
Conversation
|
mutation fail but not due to this PR |
|
It looks like most of them are around how exceptions look like: more testing addions, perhaps? We could also remove the |
|
@fezfez rebasing should solve CI issues here |
done |
|
Oof, still one mutant left 😰 |
|
Done BTW: more rebasing work 😬 |
done |
phpunit.xml.dist
Outdated
| processIsolation="false" | ||
| backupGlobals="false" | ||
| > | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" bootstrap="./vendor/autoload.php" colors="true" stopOnFailure="false" processIsolation="false" backupGlobals="false" cacheDirectory=".phpunit.cache"> |
There was a problem hiding this comment.
Can we keep the old formatting here? I find it easier to read with the previous layout.
phpunit.xml.dist
Outdated
| backupGlobals="false" | ||
| > | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" |
There was a problem hiding this comment.
Why has this namespace schema location changed?
There was a problem hiding this comment.
this is produced by using the command provided by phpunit 10 (--migrate-schema)
There was a problem hiding this comment.
We should reference the vendor path here, not a WWW URL
phpunit.xml.dist
Outdated
| backupGlobals="false" | ||
| > | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" |
There was a problem hiding this comment.
We should reference the vendor path here, not a WWW URL
|
Let's also check if CI is green 😁 |
|
all seem good now :) |
No description provided.