[phing] Use non-deprecated XML syntax in build.xml #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the build failures in #515, I noticed that there is an upcoming major version of the phing tool. When exploring that a little further, I noticed that the current
build.xmlfile has a mix of old and new syntax for theexecnodes. This pull request updates the syntax to be consistent with the current/new format. I didn't find an XSD to validate the XML against.Ref: phingofficial/phing#1252 (comment)
I have also expanded the short flag
-oto its long-format equivalent--optimize-autoloaderfor thecomposer installcommand, and added the--no-interactionflag.